feat: include description in workbook update requests#1791
Open
jacalata wants to merge 2 commits into
Open
Conversation
The REST API has supported workbook description since v3.20 (2023.2). Fixes #899 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Restore version threshold to 3.21 (matching Tableau REST API docs) - Restore parent_srv is None guard to exclude description (original behavior) - Update tests to reflect 3.21 boundary - Use re.search on multipart body for publish test, matching existing pattern - Fix stale sample comment Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
descriptionwas silently dropped fromworkbooks.update()requests; this fix sends it when the server is at API version 3.21+samples/explore_workbook.pyFixes #899
Test plan
test_update_description_in_request_xml— description sent at v3.21test_update_description_excluded_below_v3_21— description omitted below v3.21test_publish_description_in_request_xml— description present in publish request body🤖 Generated with Claude Code