Refactor Comms for Mattermost & Abstract Client Factory - #12
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Lambda file-sorting workflow to use the new swxsoc.comm abstraction (to support platforms like Mattermost) instead of direct Slack helpers, and adjusts the test harness/documentation accordingly.
Changes:
- Replaced Slack-specific client initialization + notification calls with
get_comms_client()andcomms_client.send_notification(...). - Updated pytest fixtures to stub the new comms client factory during unit tests.
- Added/adjusted environment setup for comms platform selection in tests (and made a small doc edit).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
lambda_function/src/file_sorter/file_sorter.py |
Refactors notification wiring from Slack helpers to the comms client factory + send_notification. |
lambda_function/tests/conftest.py |
Updates autouse fixture to monkeypatch get_comms_client instead of Slack helpers. |
lambda_function/tests/test_file_sorter.py |
Sets COMMS_PLATFORM during environment setup for test runs. |
AGENTS.md |
Minor edit in the testing guidance snippet (currently needs updating to match the new comms approach). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
=======================================
Coverage ? 79.81%
=======================================
Files ? 2
Lines ? 109
Branches ? 0
=======================================
Hits ? 87
Misses ? 22
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrates swxsoc/swxsoc#109