Migrate to use swxsoc from sdc_aws_utils - #30
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR migrates the Lambda executor away from sdc_aws_utils and onto the consolidated swxsoc package APIs, aligning timeseries recording, S3 upload, and Grafana annotation utilities with the swxsoc ecosystem.
Changes:
- Replace
sdc_aws_utilsimports/usages in the executor withswxsocequivalents (record_timeseries,push_science_file,create_annotation,parse_science_filename,reconfigure). - Update unit tests’ monkeypatch targets to match the new executor module-level imports.
- Add a
ruff.tomland switch dev/runtime requirements fromsdc_aws_utilstoswxsoc.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ruff.toml | Adds Ruff lint ignore configuration for the repo. |
| requirements.dev.txt | Replaces sdc_aws_utils with swxsoc in dev dependency set. |
| lambda_function/requirements.txt | Replaces sdc_aws_utils with swxsoc in Lambda runtime dependencies. |
| lambda_function/src/executor/executor.py | Migrates executor logic to use swxsoc modules/functions instead of sdc_aws_utils. |
| lambda_function/tests/test_executor.py | Updates monkeypatch paths to match new executor import locations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #30 +/- ##
=======================================
Coverage ? 62.69%
=======================================
Files ? 2
Lines ? 252
Branches ? 0
=======================================
Hits ? 158
Misses ? 94
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
swxsoclibrary: Replace deprecatedsdc_aws_utilsdependency withswxsocacross imports, function calls, and tests to consolidate AWS/utility functionality into the core SWxSOC library.