Conversation
|
petruki
added a commit
that referenced
this pull request
Jun 30, 2026
petruki
added a commit
that referenced
this pull request
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This pull request introduces several improvements focused on code clarity, performance, and thread management in the Switcher Client SDK. The most significant changes include switching to a single-threaded executor for asynchronous tasks, optimizing the logic for bypass and async execution, and updating the project version for ongoing development.
Threading and Executor Management:
AsyncSwitcherclass to use anewSingleThreadExecutorinstead of anewCachedThreadPool, ensuring that async tasks are executed sequentially and reducing potential concurrency issues.Performance and Code Clarity:
executemethod inAsyncSwitcherby cachingSystem.currentTimeMillis()andlogger.isDebugEnabled()to variables, reducing redundant calls and clarifying debug logic.SwitcherRequest.submit()to check if the bypass map is non-empty before accessing it, and replacedObjectsutility methods with direct null checks for better readability and slight performance gain.Dependency and Version Management:
pom.xmlfrom2.6.0to2.6.1-SNAPSHOTto indicate ongoing development.Imports Cleanup:
Objectsimport withMapinSwitcherRequest.javato match the updated code.