Fix RegexBuilder nesting coalescing - #871
Open
natecook1000 wants to merge 2 commits into
Open
Conversation
When coalescing characters in nested regexes, the coalescing method continued further than necessary when patching up coalesced elements, causing an invalid representation of the initial pattern. rdar://179863654
Member
Author
|
@swift-ci Please test Linux platform |
natecook1000
marked this pull request as ready for review
July 31, 2026 12:44
Member
Author
|
@swift-ci Please test Linux platform |
Member
Author
|
@swift Please test Linux platform |
natecook1000
force-pushed
the
fix/dsl-trailing-quantifier
branch
from
August 1, 2026 00:24
f4bbf36 to
ab3d764
Compare
Member
Author
|
@swift-ci Please test Linux platform |
stephentyrone
approved these changes
Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When coalescing characters in nested regexes, the coalescing method continued further than necessary when patching up coalesced elements, causing an invalid representation of the initial pattern.
rdar://179863654