Add SPKI certificate pinning support#910
Open
o-nnerb wants to merge 40 commits into
Open
Conversation
… get handler logic
…lementation # Conflicts: # Package@swift-6.0.swift
Contributor
Author
|
@czechboy0 @FranzBusch can you review this? |
glbrntt
requested changes
Jun 24, 2026
glbrntt
left a comment
glbrntt
left a comment
Collaborator
There was a problem hiding this comment.
Thanks! This mostly looks good but I left some feedback inline which needs addressing.
…ndle validations that throw exceptions
…rk.framework scenarios
glbrntt
reviewed
Jun 25, 2026
glbrntt
left a comment
glbrntt
left a comment
Collaborator
There was a problem hiding this comment.
This is looking good, just a couple of small things left. The e2e tests are much better now as well 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces SPKI-based certificate pinning to
AsyncHTTPClientto mitigate MITM attacks and compromised CAs.Highlights:
.strictand.auditmodes with multi-algorithm hashing (SHA-256/384/512) and constant-time comparison.