Converge traversal errors to C5 leaves - #9
Conversation
coenttb
left a comment
There was a problem hiding this comment.
BLOCKING — exact-head review of 6b03867.
Changed-surface blocker: the required swift-format lint job failed in https://github.com/swift-foundations/swift-github/actions/runs/30744866716/job/91488652436. Its diagnostics identify formatting violations in seven files changed by this PR: the three resource Client files, GitHub.Organization.Repositories.Client+all.swift, and the three changed Client test files. The failures are line-length, required line-break, and indentation violations, so this exact head does not satisfy the formatting gate.
Exact fixer: the source owner should apply Swift 6.3.3 swift-format output only to those seven changed files, push the resulting head, and return it for independent exact-head review. No source mutation, full-tier dispatch, merge, Task #6 closure, or #7 release was performed.
|
Formatting-only replacement head: Applied
Verification:
Push receipt: |
coenttb
left a comment
There was a problem hiding this comment.
SOURCE-CLEAN — exact-head re-review of 0f49fa7.
Checked evidence: this replacement is the direct child of the previously reviewed 6b03867 (#9 (review)). Its complete delta changes exactly the seven formatter-cited files, with 31 insertions and 18 deletions consisting only of Swift 6.3.3 line wrapping and indentation. I re-read the complete two-commit, 23-file PR diff: the declared primitive dependencies, per-resource Page and Page.Error ownership, typed Either split between lifecycle and traversal failures, and corresponding traversal tests are coherent.
Task-attributed evidence from the replacement owner: Swift 6.3.3 format lint passed on all seven replacement paths; a fresh capped package test passed 17 tests; package lint exited 0 with 38 pre-existing advisories.
No changed-surface or policy blocker remains. A qualifying full-tier workflow_dispatch at this exact head is still required before landing; merge and Task #6 completion remain held until that run succeeds.
Implements the ruled C5 traversal surface from Task #6 and its page-error taxonomy.
Pagenamespaces and adds the ruled non-generic page leaves;Either<Async.Lifecycle.Error, Traversal.Error>;Verification:
workspace package test --package-path . --fresh --jobs 4passed (17 tests);workspace package lint --package-path .completed with 38 existing advisory violations.