fix: prevent await_reactivity_loss in notify_version - #16915
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/d044c80dd9a202cafdfed37b087ce01d76608681Open in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
🦋 Changeset detectedLatest commit: d044c80 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…tion in a restored reaction context
…red context, keep the helper out of the npm tarball
There was a problem hiding this comment.
Awesome! It might be worth doing a bigger change in the future, since this is an issue in a few places that would need to be wrapped in untrack. I'm in favor of not using runes for internal bookkeeping, as that's really the root of the problem. We could also have the svelte compiler disarm at the expression boundary instead of queueing? I haven't looked into this enough, but we can circle back. Better to get @Rich-Harris opinion, not really my lane.
I am going to dismiss my review this in favor of sveltejs/svelte#18694.
closes #16914
The fix was trivial, the test was painful to write and requied ai assistance
The diff is big because I bumped svelte to latest
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits