fix: server-only import guard misses entrypoints outside the project root - #16912
Open
Nic-Polumeyv wants to merge 1 commit into
Open
fix: server-only import guard misses entrypoints outside the project root#16912Nic-Polumeyv wants to merge 1 commit into
Nic-Polumeyv wants to merge 1 commit into
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/437617288c9dcc77447affdc780c1c74cdd36a79Open in |
🦋 Changeset detectedLatest commit: 4376172 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into this in a monorepo where several apps share one client hooks file. When
files.hooks.clientpoints outside the project root,vite-plugin-sveltekit-guardsilently stops detecting server-only imports reachable from it. A$app/env/privateimport in the hooks file builds cleanly instead of throwing, even though out-of-root hooks are supported (their directory is added toserver.fs.allow).The guard's import map keys go through
normalize_id, which leaves ids outside the root absolute, but entrypoints were added as root-relative manifest paths like../shared/hooks.client.js, so the upward walk never matches the hooks file and concludes the import is server-side only. Entrypoints now go through the samenormalize_id. The cwd prefix checks also gained a trailing slash, since a sibling directory whose name extends the root's was treated as inside it.