Skip to content

Add plugin CLI command guide to integrations - #1534

Merged
graphite-app[bot] merged 1 commit into
mainfrom
feat/plugin-command-modal
Aug 20, 2026
Merged

Add plugin CLI command guide to integrations#1534
graphite-app[bot] merged 1 commit into
mainfrom
feat/plugin-command-modal

Conversation

@ishaanxgupta

@ishaanxgupta ishaanxgupta commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add an “Install plugins with one command” action beside the Plugins section
image image

@ishaanxgupta
ishaanxgupta marked this pull request as ready for review August 18, 2026 16:02
@claude

claude Bot commented Aug 18, 2026

Copy link
Copy Markdown

Claude finished @ishaanxgupta's task in 1m 27s —— View job


Review Complete

  • Fetch PR diff and existing review comments
  • Analyze changed code for bugs, security issues, and logic errors
  • Submit review summary

Overview: Adds a "Plugin commands" modal showing CLI install/login/uninstall commands, plus a tabbed "Agent instructions" / "Manual instructions" setup flow for individual plugins.

Issues found: None — this looks good to ship.

The code is well-structured:

  • State management improvements: The onSuccess handler now correctly checks s.open && s.pluginId === pluginId before updating state, preventing race conditions if the user closes the modal or switches plugins mid-request
  • Better error handling: Instead of closing the modal on key generation error, it now stays open with a "Try again" button — cleaner UX
  • Proper guards in generatePluginKey: Won't fire if key already exists, loading is true, or mutation is pending
  • Good accessibility: role="tablist", aria-selected, aria-haspopup="dialog", aria-expanded, and sr-only DialogTitle are all properly implemented
  • Code consolidation: Removed the separate finishSetupPluginId dialog in favor of a unified flow through openPluginSetup
  • Defensive rendering: Falls back gracefully if dialogPlugin is undefined (though this shouldn't happen in practice since all call sites use valid plugin IDs from PLUGIN_CATALOG)

Score: 10/10


@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview: Adds a modal displaying plugin CLI commands (install, login, uninstall) accessible via a button next to the Plugins section header.

Issues found: None — this looks good to ship.

The code:

  • Correctly references all four plugin IDs (claude_code, cursor, codex, opencode) which all exist in PLUGIN_CATALOG
  • Properly reuses the existing InstallSteps component for consistent UI
  • Has good accessibility with aria-haspopup, aria-expanded, and screen-reader-only DialogTitle
  • Extends SectionRail cleanly with an optional labelSlot prop
  • Uses proper state management for the modal

Score: 10/10

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Aug 18, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
supermemory-mcp dda56e7 Aug 20 2026, 06:09 PM

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Aug 18, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
supermemory-app dda56e7 Commit Preview URL

Branch Preview URL
Aug 20 2026, 06:10 PM

@ishaanxgupta

Copy link
Copy Markdown
Contributor Author
Screenshot 2026-08-20 at 7 56 19 PM Screenshot 2026-08-20 at 7 58 38 PM

@graphite-app

graphite-app Bot commented Aug 20, 2026

Copy link
Copy Markdown

Merge activity

## Summary

- add an “Install plugins with one command” action beside the Plugins section

<img width="1280" height="651" alt="image" src="https://github.com/user-attachments/assets/a2e19a91-c94c-4a56-87c4-b72c4dbe89ba" />
<img width="1280" height="554" alt="image" src="https://github.com/user-attachments/assets/2cd4b3a4-ac30-4411-8221-baca09e90b0f" />
@graphite-app
graphite-app Bot force-pushed the feat/plugin-command-modal branch from 8a72982 to dda56e7 Compare August 20, 2026 18:07
@graphite-app
graphite-app Bot merged commit dda56e7 into main Aug 20, 2026
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants