Send Fly-Client-Agent header with metrics requests#4994
Closed
clouvet wants to merge 4 commits into
Closed
Conversation
When determineRegion fails in non-interactive mode, buildManifest returned nil, causing the deferred metrics event to have empty org/app/region/flyctl-version fields. Now buildManifest returns a partial manifest with the org/app info that was already determined, and run() populates the metrics status from it before returning. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: Daniel Graña <dangra@gmail.com>
Uses client-signals DetectOnce() to include the agent name header on metrics POST requests to flyctl-metrics. This enables the metrics service to distinguish agent-driven vs human-driven CLI commands. Works in both interactive (forked subprocess) and non-interactive paths since env vars are inherited and DetectOnce() caches its result. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Author
|
Superseded by clean rebased PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fly-Client-Agentheader to metrics POST requests sent to flyctl-metricsclientsignals.DetectOnce()which is already a dependency — detection is cached and cheapCompanion PR
client_agentPrometheus labelTest plan
go build ./internal/metrics/...passes🤖 Generated with Claude Code