fix(deploy): determine target machine state from pre-deploy state#4984
Open
rianmcguirefly wants to merge 1 commit into
Open
fix(deploy): determine target machine state from pre-deploy state#4984rianmcguirefly wants to merge 1 commit into
rianmcguirefly wants to merge 1 commit into
Conversation
rianmcguirefly
force-pushed
the
rm/update-retry-state
branch
from
3ffad7c to
1d2c401
Compare
rianmcguirefly
changed the title
On a deploy retry, updateMachineConfig rebuilt the launch input from a re-fetched oldMachine whose live State could be mid-churn (replacing/stopped/created). skipLaunch() then inferred skip_launch=true from that transient state, so updated machine was left stopped even though the machine was started prior to deploy. Make skipLaunch the single source of truth for whether a machine should run after the deploy, and always feed it a stable input: the machine's immutable pre-deploy state.
rianmcguirefly
force-pushed
the
rm/update-retry-state
branch
from
1d2c401 to
24895f1
Compare
rianmcguirefly
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
What and Why:
On a deploy retry, updated machines could be left stopped even though the machines were started prior to deploy.
Currently when retrying,
updateMachineConfigrebuilds the launch input from the current state of the machine, which could be transient from the previous deploy attempt (replacing/stopped/created), and lead to it inferring the wrong target state for the updated machine.How:
Make skipLaunch the single source of truth for whether a machine should run after the deploy, and always feed it a stable input: the machine's pre-deploy state.
Documentation