fix: correct index_attributes for indexes not on leading table columns - #1109
Open
oniani1 wants to merge 1 commit into
Open
fix: correct index_attributes for indexes not on leading table columns#1109oniani1 wants to merge 1 commit into
oniani1 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1108
The
/indexesquery joinspg_attributeagainst the index relation but filters it witha.attnum = ANY(idx.indkey), andindkeyholds the table's column numbers, not the index's. That only lines up when the index is on the table's leading columns, so composite indexes lose columns and an index on a later column drops out of the result entirely (and 404s on retrieve-by-id).Switched the join to
a.attnum > 0. The index relation's own attributes are already the index columns in index order, and the existingorder by a.attnumkeeps them in order, so this returns the full attribute list. It's the same guardcolumns.sql.tsalready uses.Added a test with a composite index and an index on a non-leading column.