Modernize solutions, improve documentation, and enhance CI workflows - #16
Open
wforney wants to merge 54 commits into
Open
Modernize solutions, improve documentation, and enhance CI workflows#16wforney wants to merge 54 commits into
wforney wants to merge 54 commits into
Conversation
apply dotnet core
modified code
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Migrate to .slnx and .NET 10 - Enable centralized NuGet package management - Add per-project test projects using MTP/TUnit Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Fix synchronous receive recursion
README.md and TestManual.md were rewritten for improved clarity, structure, and bilingual (English/Korean) explanations. Architecture diagrams were updated and reformatted with centered images and HTML alignment. TestManual.md now provides step-by-step test instructions, tool links, and a sample game screenshot, while removing outdated content. Added main.ck to store development environment window layout and state.
wforney
commented
Jul 26, 2026
| return; | ||
| } | ||
|
|
||
| while (e.BytesTransferred > 0 && e.SocketError == SocketError.Success) |
Author
There was a problem hiding this comment.
This keeps the same semantics as before, but fixes the stack overflow. But it never gets to the try below. Is that intentional or just a logic bomb?
Major refactor replacing legacy C-style class names with modern .NET/C# conventions (e.g., UserToken, Packet, NetworkService). All core networking, packet, and session management classes rewritten using modern C# features, improved encapsulation, and clearer APIs. Method and interface names updated to PascalCase. Buffer, queue, and pool management reimplemented for thread safety and clarity. Message resolver and packet serialization logic refactored. All sample and game server code updated to use new types and APIs. Added .editorconfig for consistent style enforcement. All references to old C* types replaced. Improved access modifiers, collection usage, and synchronization. Codebase now aligns with modern C# best practices for maintainability and readability.
Refactored CSampleServer for modern C# conventions and improved encapsulation: - Made CGameUser internal, applied explicit interface implementation, and renamed fields/methods to C# standards. - Removed legacy code, unused usings, and redundant comments. - Converted Program.cs to top-level statements; user management and session creation are now static methods with thread-safe user list. - Moved and simplified protocol enum under CSampleServer namespace. - Updated all references to match new structure and naming. - main.ck now opens CGameUser.cs instead of UserToken.cs. - Minor formatting and comment improvements throughout.
Refactored client and server code for clarity and modern C# style: - Renamed CGameUser to GameUser and CRemoteServerPeer to RemoteServerPeer, updating all references. - Moved RemoteServerPeer to its own file and modernized its implementation. - Updated client and server Program.cs to use top-level statements and simplified logic. - Declared protocol enum directly in CSampleClient namespace. - Modernized method signatures and removed unused usings/comments. - Updated test and solution metadata for new file names and line numbers.
Major refactor replacing legacy C-style classes with idiomatic C#: - Renamed all core types to PascalCase and updated to use properties, modern collections, and expression-bodied members. - Introduced StateManager<T, T2> and MessageDispatcher<T, T2> for improved state and message handling. - Updated IState/IUserState interfaces and separated room/user state logic into dedicated files. - Moved protocol enum and logic to protocol.cs with better docs. - Refactored Vector2 as a struct with operator overloads. - Updated .editorconfig for modern C# style enforcement. - Updated tests and entry point to use new types. - Removed legacy files and added favorites.json for .editorconfig. This improves maintainability, readability, and aligns with C# best practices.
Refactored codebase for modern C# conventions: - Used 'var' for obvious types. - Converted simple methods to expression-bodied members. - Updated test assertions to discard results with '_ = await ...'. - Reordered and moved test methods for clarity. - Removed unused usings and improved formatting. - Renamed variables for clarity. No functional changes; all updates are stylistic.
- Added extensive unit tests for FreeNet and VirusWar server: core infra, network service, session lifecycle, and game logic. - Set logic thread as background for test isolation. - Improved UserToken.Close() with null checks to prevent NREs. - Ensure UserToken.ProcessSend always closes on send failure. - Added InternalsVisibleTo for test assemblies. - Updated main.ck for active document path change.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces comprehensive repository-wide improvements to developer experience, automation, and documentation. It establishes clear guidance for agents and contributors, adds CI workflows for build/test/coverage, and ensures protocol and threading invariants are well-documented and enforced. Several configuration and helper files are added for local development, Copilot, and MCP integration. It also adds a basic test project for the sample client.
Repository guidance and conventions
AGENTS.md,.clinerules,.cursorrules, andCLAUDE.mdto define canonical repository instructions, protocol/threading constraints, and agent priorities. These files centralize rules for packet compatibility, threading, protocol IDs, and PR workflow. [1] [2] [3] [4].github/copilot-instructions.mdfor Copilot-specific build, test, and protocol conventions, and.github/prompts/with prompt templates for manual testing and protocol-safe changes. [1] [2] [3]Continuous Integration and PR workflow
.github/workflows/build-test.ymlfor CI: builds, tests, and collects coverage for bothFreeNet.slnxandviruswar_server.slnxon PRs and pushes. Coverage is summarized and commented on PRs..github/PULL_REQUEST_TEMPLATE.md) to guide contributors in documenting changes, testing, and risk.Local development and configuration
.vscode/tasks.jsonfor one-click restore, build, and run tasks for main and sample projects..mcp.json.exampleand.github/mcp-setup.mdfor easy Model Context Protocol (MCP) integration and setup. [1] [2]Testing improvements
CSampleClient.Testswith a basic protocol stability test, and updatedCSampleClientto .NET 10 and enabled implicit usings. [1] [2] [3]Other
.contextkeeper/.git-branches/main.ckfor context preservation in compatible tools.These changes collectively improve onboarding, enforce protocol safety, automate CI, and clarify expectations for all contributors and agents.