Consistency check 2 - #244
Draft
stutiibm wants to merge 12 commits into
Draft
Conversation
The 'Emit per-UBI outputs' step previously had a safety net that
silently filled empty SCRIPT_UBI* slots by reading '# Tested on'
directly from changed .sh files. This masked two real misconfigurations
that would only surface later when Currency-build ran and silently
produced an incomplete build (e.g. only UBI9, skipping UBI10).
Replace the silent filler with a hard-stop validator that enforces
two mandatory rules on every changed .sh file:
1. '# Tested on' header is mandatory.
A script missing this header now fails the PR immediately with
a clear error message instead of being silently skipped.
2. The UBI slot for each changed script must already be populated
by read_buildinfo.sh via the version block in build_info.json.
An empty slot indicates a version block key mismatch (e.g. key
"1.5.4" vs VERSION="v1.5.4") that would cause Currency-build to
fall back to the "*" wildcard and skip the affected UBI variant.
If either rule is violated the step exits with code 1, blocking the
PR merge. Currency-build has no equivalent safety net, so catching
these errors at PR time is the correct enforcement point.
Add validation for version block key against version field
…x_for_pr_and_currency_yaml ci: replace silent safety net with hard validation in pr-build.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
set -eoption enabled and observe success ?