Send SessionInit before streaming quickload decode#843
Merged
Conversation
Split QuickLoad into Open (cheap existence check) and Finish (slow streaming decode) so the linear resume path can emit SessionInit and start keepalives before the decode. A large or remote quicksave could otherwise stream for a long time with zero client output, risking a gateway/client idle-timeout before the trace id ever arrived. The old quickload-success path also never emitted a SessionInit at all. All SessionInit emission funnels through sendSession with a once-guard, so a quickload that emits its linear session and then falls back to a full rebuild cannot produce a second, conflicting session. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Author
🔍 Vulnerabilities of
|
| digest | sha256:de388376f4174914e4802d0f36dab7b982307448340ac69971350574f07d5413 |
| vulnerabilities |     |
| platform | linux/amd64 |
| size | 109 MB |
| packages | 354 |
📦 Base Image ubuntu:24.04
| also known as |
|
| digest | sha256:52df9b1ee71626e0088f7d400d5c6b5f7bb916f8f0c82b474289a4ece6cf3faf |
| vulnerabilities |   |
UlysseCorbeil
approved these changes
Jul 14, 2026
maoueh
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Split
QuickLoadintoQuickLoadOpen(cheap: confirm quicksave files exist/readable) +QuickLoadFinish(slow: stream-decode into stores). The tier1 linear resume path now emitsSessionInit(trace id) and starts keepalives between open and finish.Why
A large or cold/remote quicksave store could stream-decode for a long time with zero output to the client, risking a gateway/client idle-timeout before the trace id ever arrived. The old quickload-success path additionally never emitted a
SessionInitat all.All
SessionInitemission now funnels throughsendSessionwith a once-guard (sessionInitSent), so a quickload that emits its linear session and then falls back to a full rebuild cannot produce a second, conflicting session.Notes
QuickLoadClose, idempotent) and bbolt backends (closeQuickloadStores); a corrupt/truncated quicksave falls through to a full rebuild exactly as a missing file would.🤖 Generated with Claude Code