hotfix: wire StoreSizeLimit into tier1 linear pipeline#842
Merged
Conversation
Contributor
Author
UlysseCorbeil
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Operators set
StoreSizeLimit(e.g. 3.5GiB) but tier1's own linear (dev-mode) pipeline still tripped at the 1GiB default:service/tier1.gohardcoded0when building its storeConfigMap, so it always fell back toDefaultStoreSizeLimit. Tier2 subrequests received the limit correctly viaProcessRangeRequest; only tier1's linear path ignored it.Fix
StoreSizeLimittoRuntimeConfig(next toStoresScratchSpace/StoresBackend) +WithStoreSizeLimitoption, wired from the tier1 app config.ConfigMapnow passesruntimeConfig.StoreSizeLimitinstead of0.Test
TestStoreSizeLimitsets a 1-byte limit on the tier1 linear pipeline and assertsErrStoreAboveMaxSize. Verified it fails if the wiring regresses (limit dropped back to0).Additional e2e tests fixes