increment: enhance CmsService locale handling with validation and tests - #179
Merged
timosville merged 4 commits intoJul 31, 2026
Conversation
Deploying kit with
|
| Latest commit: |
9613165
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://edefab46.kit-atq.pages.dev |
| Branch Preview URL: | https://sco-2800-querying-a-locale-t.kit-atq.pages.dev |
JannieT
approved these changes
Jul 31, 2026
JannieT
left a comment
JannieT
left a comment
Member
There was a problem hiding this comment.
Good catch!
Looks like there are two regressions on the invitation validator (Invitation validator › Live Schema › allows empty actionUrl). Because we do not run the test suite on PR it might have been around for a while.
Before merging, please see if you can fix the tests and look at my comments
timosville
deleted the
sco-2800-querying-a-locale-that-does-not-exist-in-the-cms-returns-500
branch
July 31, 2026 12:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.