Changes to Storm for revised belief exploration - #1028
Open
AlexBork wants to merge 1 commit into
Open
Conversation
sjunges
reviewed
Aug 19, 2026
| std::optional<TimeBound> BoundedUntilFormula::getUpperBoundAsOptionalTimeBound(unsigned i) const { | ||
| if (hasUpperBound(i)) { | ||
| return upperBound.at(i).get(); | ||
| } else { |
Contributor
There was a problem hiding this comment.
Why not just return upperBound.at(i) rather than the case split (we would need to move from boost to std then, but that would be good anyways.
sjunges
reviewed
Aug 19, 2026
| @@ -0,0 +1,23 @@ | |||
| #pragma once | |||
Contributor
There was a problem hiding this comment.
What happens here if InputType == OutputType? Why do we ever want those instantiations?
What do we do if we go from doubles to rational numbers to ensure that probabilities still sum to one?
sjunges
reviewed
Aug 19, 2026
| #include <string> | ||
| #include <vector> | ||
|
|
||
| #include "storm/models/sparse/Model.h" |
Contributor
There was a problem hiding this comment.
Some simple test cases for this would be good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains changes to Storm outside Storm-POMDP for the revised belief exploration implementation, see PR #1004.