Conversation
Note this does not affect the abilily to have particles of different radii, this is simply fixing the no. of dofs per particle, not the radius of each particle. That's currently limited by having a single parameter per electrode.
nmnobre
force-pushed
the
opt
branch
4 times, most recently
from
August 18, 2026 10:38
b563479 to
368498e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems to fix all issues with Valgrind. Improves P2D performance.
Using MOOSE's MFEM
oprofconfig, and reportinguser, /not/realtime, best of five runs: 4.906s vs 5.884s.