Bump UpgradeCoreResourceRequirements to handle larger pubnet RAM#404
Open
graydon wants to merge 1 commit into
Open
Bump UpgradeCoreResourceRequirements to handle larger pubnet RAM#404graydon wants to merge 1 commit into
graydon wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts Kubernetes resource requirements for upgrade tests to prevent OOM kills when rebuilding Soroban state in-memory, especially in larger pubnet-like runs.
Changes:
- Increased
UpgradeCoreResourceRequirementsmemory request/limit to accommodate higher peak RAM usage.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
138
to
+140
| // When doing upgrade tests, we give each container | ||
| // 256MB RAM and 1 vCPU, bursting to 4vCPU and 14GB | ||
| makeResourceRequirements 1000 256 4000 14000 | ||
| // 6000MB RAM and 1 vCPU, bursting to 24000MB and 4 vCPUs | ||
| makeResourceRequirements 1000 6000 4000 24000 |
jayz22
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UpgradeCoreResourceRequirementsis used in both small upgrade tests and larger ones run against pubnet. This limit was last lowered back in 9c2defc (when the test was changed to use a disk-backed emptyDir) but lately we've switched to storing live soroban state in memory and it seems that the peak use during in-memory state rebuild has tipped over the 14GiB limit and we're getting OOMKilled during tests. So we're just bumping it back up here.