fix: unmarshal comment_options extensions from condenser API#9
Merged
Conversation
condenser_api returns comment_options extensions as [tag, value] static_variant tuples. Add CommentOptionsExtension.UnmarshalJSON so GetOpsInBlock can parse blocks containing beneficiary extensions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CommentOptionsExtension.UnmarshalJSONfor condenser_api[tag, value]static_variant tuplescomment_optionsoperation JSONMotivation
GetOpsInBlockfails on blocks with beneficiary extensions (e.g. block 61570519):cannot unmarshal array into Go struct field protocol.CommentOptionsOperation.extensionsTest plan
go test ./protocol/ -run CommentOptions