Skip to content

test: migrate stats/base/dists/kumaraswamy/mode to ULP-based assertions - #14426

Merged
kgryte merged 1 commit into
developfrom
kgryte/ulp-stats-base-dists-kumaraswamy-mode
Aug 20, 2026
Merged

test: migrate stats/base/dists/kumaraswamy/mode to ULP-based assertions#14426
kgryte merged 1 commit into
developfrom
kgryte/ulp-stats-base-dists-kumaraswamy-mode

Conversation

@kgryte

@kgryte kgryte commented Aug 20, 2026

Copy link
Copy Markdown
Member

Resolves a part of #11352.

Description

What is the purpose of this pull request?

This pull request:

  • migrates the tests for stats/base/dists/kumaraswamy/mode from relative tolerance assertions to ULP-based assertions using @stdlib/assert/is-almost-same-value.
  • updates both test/test.js and test/test.native.js, replacing the delta/tol comparison against 15.0 * EPS * abs( expected[ i ] ) with t.strictEqual( isAlmostSameValue( y, expected[ i ], 1 ), true, 'returns expected value' );.
  • removes the now unused @stdlib/math/base/special/abs and @stdlib/constants/float64/eps requires.

The final ULP constant is 1 in both test/test.js and test/test.native.js.

This is the measured minimum. Over the full Julia fixture set (100 cases), the largest observed ULP difference between the returned and expected values is exactly 1 (worst case: a = 4.650703332395438, b = 3.5899547415339503, returned 0.7308091452905936, expected 0.7308091452905935). Lowering the bound to 0 fails 14 of the fixture cases in each test file, so 1 is the tightest bound which passes.

Both test files were run twice at the final bound to confirm determinism (the native tests were exercised locally after building the add-on): test/test.js 120/120 passing and test/test.native.js 121/121 passing on both runs. Only the two test files are modified.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was written by Claude Code, running unattended, which selected the package, mirrored the idiom used in previously merged migrations, measured the minimum ULP bound against the fixture set, and verified the tests and lint locally.


@stdlib-js/reviewers


Generated by Claude Code

…ions

Ref: #11352

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: skipped
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Good First PR A pull request resolving a Good First Issue. labels Aug 20, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/kumaraswamy/mode $\\color{green}205/205$
$\\color{green}+100.00\\%$
$\\color{green}12/12$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}205/205$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte added the Tests Pull requests specifically adding tests. label Aug 20, 2026
@kgryte
kgryte marked this pull request as ready for review August 20, 2026 10:39
@kgryte
kgryte requested a review from a team August 20, 2026 10:39
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Aug 20, 2026
@kgryte
kgryte merged commit 274f42b into develop Aug 20, 2026
82 checks passed
@kgryte
kgryte deleted the kgryte/ulp-stats-base-dists-kumaraswamy-mode branch August 20, 2026 10:40
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality. Tests Pull requests specifically adding tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants