Exclude built assets from git - #2
Open
duncanmcclean wants to merge 1 commit into
Open
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Member
Author
|
@jasonvarga I'm assuming this is the plan for addons going forward? (copying how we do it in core with the manually triggered workflow) |
Member
|
Looks good but the two secrets only exist on cms. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes the built Control Panel assets from the repository and adds a release workflow which builds them at release time, matching how we handle assets in
statamic/cms.Keeping compiled assets out of version control has a few benefits:
distfiles.Releasing
To tag a release, run the "Create Release" workflow from the Actions tab and give it a version number. It'll build the assets, commit them onto the tag, and create the GitHub release using notes from the
CHANGELOG.mdthis PR also adds.