[6.x] Add a "compact mode" for the array fieldtype - #15219
Merged
Conversation
…alue, and the read-only trigger
…odal" This reverts commit 72bb6ea. because it breaks a combobox in a popover, e.g. multisite > entry > change localization > which gets you a "Create Localization" modal with a combobox in it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Problem
The array fieldtype could do with a "compact mode" when being used within a grid.
This is handy when we don't need all the details up front – like for custom attributes in a sites table here
These details could be tucked away:
What this PR Does
/cp/sitesat the momentEscstill worksenterin the middle of the array adds a row below rather than to the end. This would be useful if you'd like to insert missing detail to the array.z-indexhelper for confirmation modals. This was needed so the confirmation modal stays above the compact array popoverHow to Reproduce
/cp/sitesin the "Custom Attributes" column