SIP-044: Clarity 6, staking and PoX post-conditions, and removal of the cost-voting contract#267
SIP-044: Clarity 6, staking and PoX post-conditions, and removal of the cost-voting contract#267jbencin-stacks wants to merge 25 commits into
Conversation
|
I think it is convenient to give this a SIP number right away for ease of referencing lets go with SIP-044 |
|
@jbencin-stacks thanks for adding these items to the SIP. I see you changed the title, and removed the SIP-044 number. Lets keep the SIP number in the title of this issue it has already been referenced elsewhere. The work to deal with problematic transactions I don't think need mention in the title. |
| | field | size | encoding | | ||
| | ---------- | ------- | -------------- | | ||
| | `tx_index` | 4 bytes | big-endian u32 | | ||
| | `category` | 1 byte | u8 | |
There was a problem hiding this comment.
What are examples for categories? How are they defined?
There was a problem hiding this comment.
This is intentionally left undefined. An example of a transaction that would end up in here would be something that would currently be silently dropped from the mempool, that the miner considers "problematic" due to some case that it hits that it shouldn't have. If 70% of the signers agree that it is problematic, then it would be allowed to be included in this list. The category would identify what kind of issue it hit.
Editors have approved and the SIP can move to CAB votes.
314159265359879
left a comment
There was a problem hiding this comment.
This is looking great for editor sign-off, thanks!
314159265359879
left a comment
There was a problem hiding this comment.
I have a few more suggestions before we merge this.
| none | ||
| )) | ||
| );; Returns (err u0) | ||
| (restrict-assets? tx-sender ((with-stacking u1000000000000)) |
There was a problem hiding this comment.
((with-stacking u1000000000000))
this needs to be "with-staking"
There was a problem hiding this comment.
To show the success path, one of the two numbers must change too, right?:
Raise the allowance: (with-staking u1100000000000) with the stake call unchanged, or
Lower the stake: keep (with-staking u1000000000000) and stake u1000000000000.
probably a copy/paste mistake.
|
|
||
| Parts of this SIP depend upon | ||
| [SIP-045 (Bitcoin Staking)](https://github.com/adriano-stacks/sips/blob/main/sips/sip-xxx/sip-0XX-pox-5-bitcoin-staking.md) | ||
| and intends to activate together with it. |
There was a problem hiding this comment.
grammer and sementics error here with this sentence. I suggest this instead:
Parts of this SIP depend upon SIP-045 (Bitcoin Staking), and this SIP is intended to activate together with it.
(not other issue about link)
|
|
||
| Discussions-To: | ||
|
|
||
| # Abstract |
There was a problem hiding this comment.
Abstract and Introduction omit the staking post-conditions, although they are in the title and the specification defines the identifiers.
There was a problem hiding this comment.
Oops, those post-conditions were moved into SIP-045. I will clean that up.
| | yes | `11111111111mdWK2VXcrA1f72DmUku` | `SP00000000001WPAWSDEDMQ0B9M6HQVS7Q6` | `7965732d7369702d3434` | yes-sip-44 | | ||
| | no | `111111111111ACW5wa4RwyfJspnNhu` | `SP000000000006WVSDEDMQ0B9M6K3NTSJK` | `6e6f2d7369702d3434` | no-sip-44 | | ||
|
|
||
| If the SIP is approved, a Bitcoin block height will be selected to activate the |
There was a problem hiding this comment.
To make sure activation criteria is falsifiable replace this sentence
If the SIP is approved, a Bitcoin block height will be selected to activate the new behavior.
with:
Voting will take place over the same voting window as SIP-045, to be identified during the community review period, following the precedent of SIP-021 and SIP-029 of finalizing block heights during vote preparation. If the criteria are not met within that window, the SIP is Rejected.
If approved, the activation block height will be finalized during vote preparation, together with SIP-045.
| In order for this SIP to activate, the following criteria must be met: | ||
|
|
||
| - At least 80 million stacked STX must vote, with at least 80% of all stacked | ||
| STX committed by voting must be in favor of the proposal (vote "yes"). |
There was a problem hiding this comment.
Replace the first bullit with this to avoid two readings:
- At least 80 million stacked STX must participate in the vote, and at least
80% of all stacked STX committed by voting must be in favor of the proposal
(vote "yes").
| block height at which the voting started (preventing the same STX from being | ||
| transferred between accounts and used to effectively double vote). | ||
|
|
||
| Solo stackers only can also vote by sending a bitcoin dust transaction (6000 |
There was a problem hiding this comment.
and while were are here
"Solo stackers only can" → "Only solo stackers can"
There was a problem hiding this comment.
I think the correct meaning we want would be to just drop the "only". I think it should just say "Stackers can also vote..."
There was a problem hiding this comment.
Actually, no it needs to be more specific than that, right? Like your voting power is based on the source Bitcoin address matching your PoX address, so it is "Solo stackers only".
There was a problem hiding this comment.
I'm going to make it,
Solo stackers can also vote by sending a bitcoin dust transaction (6000 sats) to the corresponding bitcoin address, from their PoX address.
|
|
||
| License: BSD-2-Clause | ||
|
|
||
| Sign-off: |
There was a problem hiding this comment.
when the status updates add a line here. Editor sign-off was on the 6th of July #267 (review)
CAB sign-off etc.
|
@314159265359879 your comments are all addressed in 93980a2. Thanks! |
Note
This is a work in progress, and more items will likely be added to Clarity 6
This SIP specifies the next version of the Stacks blockchain scripting language, Clarity 6, which addresses several limitations and inconveniences that have been reported by Clarity developers.