Skip to content

feat(cdn) - Feature parity - #1601

Merged
cgoetz-inovex merged 11 commits into
stackitcloud:mainfrom
matheuspolitano:mp/cdn/feature-parity
Aug 14, 2026
Merged

feat(cdn) - Feature parity#1601
cgoetz-inovex merged 11 commits into
stackitcloud:mainfrom
matheuspolitano:mp/cdn/feature-parity

Conversation

@matheuspolitano

@matheuspolitano matheuspolitano commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Description

(https://jira.schwarz/browse/STACKITCDN-1451)

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Acceptance tests got implemented or updated (see e.g. here)
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@matheuspolitano
matheuspolitano requested a review from a team as a code owner July 21, 2026 13:48
@cgoetz-inovex

Copy link
Copy Markdown
Contributor

Hi @matheuspolitano,
thanks for your contribution, I've created an internal issue to review and test this PR.

@github-actions

Copy link
Copy Markdown

This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it.

@github-actions github-actions Bot added the Stale PR is marked as stale due to inactivity. label Jul 30, 2026
@rubenhoenle rubenhoenle removed the Stale PR is marked as stale due to inactivity. label Jul 30, 2026
Comment thread stackit/internal/services/cdn/distribution/datasource_test.go
Comment thread stackit/internal/services/cdn/distribution/resource_test.go
Comment thread stackit/internal/services/cdn/distribution/resource.go Outdated
Comment thread stackit/internal/services/cdn/distribution/resource.go
Comment thread stackit/internal/services/cdn/distribution/resource.go
Comment thread stackit/internal/services/cdn/distribution/resource.go
Matheus Politano added 4 commits August 10, 2026 15:37
The blocked_ips attribute is Optional+Computed without a default, so it
can be unknown at plan time. Decoding it into a *[]string field failed
with 'Received unknown value, however the target type cannot handle
unknown values'.

Change the BlockedIps field in distributionConfig from *[]string to
types.List and guard reads with utils.IsUndefined before converting
elements via ElementsAs.
Manuelvaas
Manuelvaas previously approved these changes Aug 13, 2026
Comment thread stackit/internal/services/cdn/distribution/resource.go
Comment thread stackit/internal/services/cdn/distribution/resource.go Outdated
Comment thread stackit/internal/services/cdn/distribution/resource.go Outdated
Comment thread stackit/internal/services/cdn/distribution/datasource.go
- Collapse DefaultCacheDuration and MonthlyLimitBytes mapping to
  types.StringPointerValue / types.Int64PointerValue since a nil pointer
  already yields the framework null value.
- Extend descriptions for the new Optional+Computed attributes
  (blocked_ips, default_cache_duration, monthly_limit_bytes) to clarify
  that removing the attribute from HCL retains the last known value in
  state. Regenerate resource and datasource docs.
@cgoetz-inovex
cgoetz-inovex merged commit fc4f447 into stackitcloud:main Aug 14, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants