Set kolla base version with ansible facts#2389
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request replaces the static mapping for kolla_base_distro_version with a direct reference to ansible_facts.distribution_major_version. However, this change will break deployments on non-Rocky distributions (such as Debian, Ubuntu, and CentOS) because they expect codenames or specific formats rather than just the major version number. To address this, a dynamic mapping using Ansible facts should be implemented as suggested.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
owenjones
force-pushed
the
use-host-version
branch
2 times, most recently
from
3544db1 to
4a4f11d
Compare
Switch to setting `kolla_base_distro_version` using ansible facts, rather than a static mapping, so the correct containers get deployed on hosts when we have a mixture of versions (during Rocky 9 to 10 migration).
owenjones
force-pushed
the
use-host-version
branch
from
4a4f11d to
0ed6365
Compare
1 participant
Switch to setting
kolla_base_distro_versionusing ansible facts, rather than a static mapping, so the correct containers get deployed on hosts when we have a mixture of versions (during Rocky 9 to 10 migration).