feat(rwnd): add rwnd trace and its unit test#26
Open
zhang-hc22 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR solves issue #25
Description
This PR adds receive window (rwnd) trace support to netem-trace, enabling simulation and replay of TCP receiver-side behaviour over time.
Each step in a rwnd trace is described by four fields:
Exactly one of app_read_bytes / rwnd_remaining must be set per step, never both and never neither. This invariant is enforced at two levels: deserialization rejects invalid inputs with a clear error message, and StaticRwndConfig::build() panics for programmatically-constructed configs that omit both.
New public surface in src/lib.rs:
New model module src/model/rwnd.rs (enabled via rwnd-model / model feature):
The rwnd-model feature is added to the model umbrella feature and follows the same dependency pattern as loss-model and duplicate-model (dep:dyn-clone).
How Has This Been Tested
cargo test --features "model,serde" # 22 unit + 47 doc — all pass
cargo test --features "model,serde,human" # 23 unit + 47 doc — all pass
Types of changes
Checklist
Other information
The RwndAction / RwndDecision types are placed in lib.rs alongside BwTrace, LossTrace, etc., matching twnd-model feature follows the same opt-in pattern as other model features and is included in the modelumbrella and full feature set.