-
Notifications
You must be signed in to change notification settings - Fork 152
Anytopo test reference and packaging updates #2713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
berquist
wants to merge
4
commits into
sstsimulator:devel
Choose a base branch
from
berquist:update_merlin_anytopo_jellyfish_test
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+26
−2
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
d3c90c0
Update test_merlin_anytopo_jellyfish_test.out
berquist cedd99b
Add missing anytopo tests and reference outputs to Makefile.am
berquist c6f66fd
Add missing anytopo_utility to Makefile.am
berquist af2e8e8
Use non-zero fixed seed for anytopo Jellyfish
berquist File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
src/sst/elements/merlin/tests/refFiles/test_merlin_anytopo_jellyfish_test.out
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| Loaded NetworkX graph with 16 vertices and 32 edges | ||
| Offered Average | ||
| Load Latency | ||
| 0.50 268.375 ns | ||
| 0.50 262.401 ns | ||
|
|
||
| Simulation is complete, simulated time: 400 us | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused why this test failed: https://sst-jenkins.sandia.gov/job/SST__Autotest_OSX-15-XC16_OMPI-4.1.6_PY3.10_sst-elements/1320/consoleFull
It looks like it's complaining but the change is exactly what you made here???
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The SHA of the commit being used is correct. It shouldn't be from testing the merge with
devel, since that's what running locally also defaults to. I'll try running locally on that machine, without the SQE changes in sstsimulator/sst-sqe#1245, and also look at the Jenkins config for this job.I am surprised that the test is being executed at all, which means the Python dependencies are present on that machine (not sure how).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To the last point, I am seeing failures on nightlies for a few of these tests now, for tests that pass on the head node.
I am not sure how we normally handle (floating point) differences in required reference data for different machines, I'll need to look at the testing framework.