feat(web): set a heat pump's curve offset from the Heating view #749
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| --- | ||
| "ftw": minor | ||
| --- | ||
|
|
||
| The Heating view can now set a heat pump's curve offset. A pump whose driver | ||
| declares a control gets a row on its card: the value in force, when the hold | ||
| ends, and buttons to move it or release it. A pump that declares nothing looks | ||
| exactly as it did. | ||
|
|
||
| It lives on the Heating card rather than in Settings → Devices because that is | ||
| where the pump's own state already is — the offset sits next to the | ||
| temperatures it moves. Settings is for connecting a device, not for running it. | ||
|
|
||
| Rendered entirely from the declaration: label, bounds, step and unit come from | ||
| the driver, and nothing in the view knows a driver by name. Stepper buttons | ||
| rather than a slider or a number field, because the card is re-rendered every | ||
| 30 s and a control holding input state would lose a half-typed value on each | ||
| refresh. | ||
|
|
||
| With no hold the row reads "Auto" rather than a number. Nothing in the browser | ||
| knows what offset the pump has settled on internally, and printing 0 would | ||
| claim knowledge we do not have. Held state is carried by the text and the | ||
| weight of the value, never by colour: the theme's green/red pair is not | ||
| separable under deuteranopia. | ||
|
|
||
| A driver that declares `evidence: "write_ack"` instead of `"readback"` says so | ||
| in the row — "the pump does not confirm this setting". The weaker guarantee | ||
| belongs where the operator is standing. |
Empty file.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| import test from 'node:test'; | ||
| import assert from 'node:assert/strict'; | ||
| import { readFileSync } from 'node:fs'; | ||
|
|
||
| const source = readFileSync(new URL('./heating.js', import.meta.url), 'utf8'); | ||
|
|
||
| // These guard the invariants that break silently. The behaviour itself was | ||
| // verified against a running FTW and a probe driver: pressing + drove the | ||
| // driver's own hp_z1_heat_offset metric to 1, raise disabled at the declared | ||
| // +3, Release returned the metric to 0 via driver_default_mode, and a click | ||
| // on the control did not open the all-signals detail while a click on the | ||
| // card still did. | ||
|
|
||
| test('the control is rendered from the driver declaration, never from a driver name', () => { | ||
| assert.match(source, /function controlBlock\(name, detail\)/); | ||
| assert.match(source, /firstNumberControl\(detail\)/); | ||
| // No control branch may key on a driver id — that is the mistake Settings | ||
| // made, and the reason a declared control exists at all. Scoped to the | ||
| // control code: the file's telemetry half names drivers freely and should. | ||
| const start = source.indexOf('// ---- Control: one declared command per pump ----'); | ||
| const end = source.indexOf('// ---- Detail drill-in'); | ||
| assert.ok(start > 0 && end > start, 'control section markers moved'); | ||
| assert.doesNotMatch(source.slice(start, end), /heishamon|myuplink|nibe_local/i); | ||
| }); | ||
|
|
||
| test('a pump that declares nothing renders nothing', () => { | ||
| assert.match(source, /if \(!control\) return '';/); | ||
| }); | ||
|
|
||
| test('bounds and step come from the declaration, not from constants here', () => { | ||
| assert.match(source, /input\.step === 'number' && input\.step > 0 \? input\.step : 1/); | ||
| assert.match(source, /typeof input\.min === 'number' && value <= input\.min/); | ||
| assert.match(source, /typeof input\.max === 'number' && value >= input\.max/); | ||
| }); | ||
|
|
||
| test('commanding the pump does not navigate into its signals', () => { | ||
| // The whole card is a button; without stopPropagation the detail view opens | ||
| // over the control the operator just pressed. | ||
| assert.match(source, /closest\('\.ftw-hpc-btn'\)[\s\S]{0,120}e\.stopPropagation\(\)/); | ||
| assert.match(source, /closest\('\.ftw-hpc-release'\)[\s\S]{0,120}e\.stopPropagation\(\)/); | ||
| }); | ||
|
|
||
| test('no hold reads as Auto rather than a number we do not know', () => { | ||
| assert.match(source, /ftw-hpc-auto">Auto</); | ||
| }); | ||
|
|
||
| test('held state is carried by text and weight, not by colour alone', () => { | ||
| // The theme's green/red pair is not separable under deuteranopia, so the | ||
| // control must not encode its state in colour. | ||
| const styles = source.slice(source.indexOf('.ftw-hpc{'), source.indexOf('.ftw-hpc-err{')); | ||
| assert.doesNotMatch(styles, /var\(--green\)|var\(--red\)|var\(--accent\)/); | ||
| assert.match(source, /\.ftw-hpc-value\{[^}]*font-weight:600/); | ||
| }); | ||
|
|
||
| test('a driver that cannot confirm its writes says so in the UI', () => { | ||
| assert.match(source, /control\.evidence === 'readback'/); | ||
| assert.match(source, /does not confirm this setting/); | ||
| }); | ||
|
|
||
| test('the operator sees the result of a press even mid-refresh', () => { | ||
| // refresh() drops overlapping calls, which is right for the 30 s timer and | ||
| // wrong immediately after a button press. | ||
| assert.match(source, /function refreshAfterControl\(\)/); | ||
| assert.match(source, /if \(!refreshInFlight\) \{ refresh\(\); return; \}/); | ||
| }); | ||
|
|
||
| test('stepper buttons rather than an input that a re-render would clear', () => { | ||
| // The card is re-rendered wholesale every 30 s. | ||
| assert.doesNotMatch(source, /class="ftw-hpc[^"]*"[^>]*<input/); | ||
| assert.match(source, /data-hpc-value="/); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the pump's autonomous/default offset is nonzero, this initializes the stepper at zero even though the following comment acknowledges that the current value is unknown. For example, if
driver_default_modehas settled at +2 °C, pressing “Raise” sends +1 °C and actually makes the target cooler for the next four hours. Read the current offset from telemetry before offering relative controls, or require an explicit absolute selection when leaving Auto.Useful? React with 👍 / 👎.