Remove SprigUI, add a BaseOS tab - #32
Merged
Merged
Conversation
SprigUI is archived — spruceOS supports the Miyoo Mini Flip properly now, so the tab pointed at a dead repo. BaseOS (pvaibhav/BaseOS) is a third-party minimal OS for Anbernic RG XX devices, added here as an install target. It ships .img.zip: a raw disk image inside a zip container. The installer classified anything ending in .zip as an archive to extract onto a formatted card, so a BaseOS install would have formatted the card and copied a 1.4 GB .img onto it rather than burning it — an unbootable card with no error. Raw-image detection now matches .img.zip, and burn.rs gained a shared open_image_reader() that streams .gz, .zip or a bare .img through one path, replacing four copy-pasted gzip blocks. A worker thread owns the ZipArchive and hands chunks over a bounded channel, since by_index borrows the archive and cannot escape into the Box<dyn Read> the burn paths expect. Zip stores its uncompressed size in the headers, so unlike .gz it needs no pre-scan. Read is deliberately fully qualified in the new code: one of the existing per-function imports is cfg-gated and guards the statement after it, so consolidating them silently breaks the Windows build. Version bumped to 1.6.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
config.rs.pvaibhav/BaseOS) as an install target — a third-party minimal OS for Anbernic RG XX devices, credited and linked as such in the tab's info text.Cargo.toml,Info.plist).Tabs are now Stable / Nightlies / TwigUI / BaseOS.
Why this isn't just a config entry
BaseOS ships
.img.zip— a raw disk image inside a zip container. The installer classified anything ending in.zipas an archive to extract onto a formatted card, so a BaseOS install would have formatted the SD card and copied a 1.4 GB.imgfile onto it instead of burning it: an unbootable card, with no error shown.So this also teaches the burn path about
.img.zip:is_raw_image_asset()inlogic.rsnow matches.img.zip, replacing three drifting inline copies of the check inlogic.rsandui.rs.burn.rsgainsopen_image_reader(), which streams.gz,.zipor a bare.imgthrough one path — replacing four copy-pasted gzip blocks. A worker thread owns theZipArchiveand hands 1 MB chunks over a bounded channel, sinceby_indexborrows the archive and can't escape into theBox<dyn Read>the burn paths expect..gzit needs no full-file pre-scan..img.zipis ordered before.zipinstrip_extensionsand the auto-select priority list, since every.img.zipname also ends with.zip.Readis deliberately fully qualified in the new code. One of the existing per-functionuse std::io::Read;imports is cfg-gated and guards the statement that follows it — consolidating them silently breaks the Windows build.Verification
All four workflows green on all platforms: beta-add-baseos-tab.
Selection logic dry-run against each tab's live release, using the mappings parsed out of the committed
config.rs:All 11 BaseOS devices map to friendly labels, none falling through to a raw filename.
CI proves this compiles; nothing has actually burned a card. The zip reader, the header size lookup and the read-back verification have never executed against a real image. Because the shared burn path changed, TwigUI (
.img.gz) should be smoke-tested alongside BaseOS before this is trusted in a release.🤖 Generated with Claude Code