docs(plan): name "Demand mode" explicitly in its own tooltip text - #4400
Merged
springfall2008 merged 1 commit intoJul 31, 2026
Merged
Conversation
The plain-arrow plan cells (no charge/discharge/freeze scheduled) never actually said "Demand" in their tooltip, despite that being the exact mode name shown in the mode selector and Status card elsewhere in the UI - so there was nothing connecting "this arrow-only cell" to "this is Demand mode" for anyone reading the tooltip in isolation. Also swapped "house demand" for "house load" in the same templates - the generic English word collided with the Predbat mode name enough to undercut the fix if left in place right next to it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The plain-arrow plan cells (no charge/discharge/freeze scheduled) never actually said "Demand" in their tooltip, despite that being the exact mode name shown in the mode selector and Status card elsewhere in the UI. Noticed live while reading a plan next to the Status card - nothing in the tooltip connected "this arrow-only cell" to "this is Demand mode."
demand_rising/demand_falling/demand_steadynow lead with "Demand — ...", matching the existing style offreeze_charge("Freeze charging — ...") andfreeze_export_below_threshold("Freezing export — ...").demand_before_export_*split-cell counterparts - the generic English word "demand" collided with the Predbat mode name enough to undercut the fix if left sitting right next to it.reason_templatesJSON so there's no separate copy to update.Test plan
./run_pre_commit(viacoverage/run_pre_commit) - all hooks pass./run_all --test plan_why_reason- passes (asserts reason codes, not literal text, so unaffected structurally; confirmed no test hardcodes the old strings)./run_all --quick) passes