docs: clarify read-only mode still performs one reset write on enable - #4388
Merged
springfall2008 merged 1 commit intoJul 30, 2026
Conversation
…rite switch.predbat_set_read_only is flagged as a reset_inverter_force trigger, so toggling it on deliberately fires one release write (max charge rate, clear windows/reserve/export) to hand control back to the inverter's own native scheduling - it isn't a violation of read-only mode, but it wasn't documented, so it silently overwrote a manually-set inverter value for one reporter (springfall2008#4298). Behaviour is unchanged and intentional (dates to springfall2008#519); this just makes it visible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
switch.predbat_set_read_onlyis flagged as areset_inverter_forcetrigger, so turning it on deliberately fires one release write (max charge rate, cleared charge/export windows, reserve reset) to hand the inverter back to native scheduling.Test plan
./run_pre_commit(viacoverage/run_pre_commit) - all hooks passCloses #4298