Add DelegatingGrpcAuthenticationExtractor - #425
Merged
Conversation
Spring Security exposes first-non-null converter composition as public API on both stacks, but the gRPC equivalent was a private inner class of GrpcSecurity. An application could only compose extractors through the builder, so it could not wrap a composition, pass one to another component, or test one without a full GrpcSecurity. Extract the composition into a public final class that mirrors DelegatingAuthenticationConverter, with list and varargs constructors that reject an empty argument. GrpcSecurity behaves as before: it sorts the extractors before it composes them, and a configuration with no extractor still leaves the call unauthenticated. Fixes spring-projectsgh-420 Signed-off-by: Gabriel Hall <gabriel.hall@cox.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracts the first-non-null composition out of the private
GrpcSecurity.CompositeAuthenticationExtractorinto a publicDelegatingGrpcAuthenticationExtractor, mirroringDelegatingAuthenticationConverter.Fixes #420