Remove crc32cer restriction#163
Merged
Merged
Conversation
Bumps brod and other deps as well
There was a problem hiding this comment.
Pull request overview
This PR removes the explicit :crc32cer version restriction from Kaffe’s dependency list and updates locked dependency versions (notably :brod / :kafka_protocol), alongside documentation updates to reflect the change.
Changes:
- Removes the direct
:crc32cerdependency constraint frommix.exsand bumps project version to2.1.0. - Updates
mix.lockto newer:brod,:kafka_protocol, and:crc32cerversions. - Adds documentation/changelog notes about build prerequisites after the dependency changes.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| README.md | Adds an installation prerequisite note; needs clarification/accuracy tweaks. |
| mix.lock | Updates locked versions for :brod, :kafka_protocol, and :crc32cer. |
| mix.exs | Bumps library version and removes the :crc32cer version cap. |
| CHANGELOG.md | Documents the version bump and dependency/build implication; needs rewording for correctness. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fatcatt316
approved these changes
Jul 17, 2026
Contributor
There was a problem hiding this comment.
All tests passed once I installed cmake and updated the test config. Nice unblocking of this issue 👏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the crc32cer < 1.0 restriction from kaffe. This requires a new build dependency in cmake for projects not using it before, but can be opted out of by manually restricting crc32cer to
< 1.0.0.