fix: Auto-update package.json FileVersion when downloading new spec files - #196
Open
jtgreen86 wants to merge 8 commits into
Open
fix: Auto-update package.json FileVersion when downloading new spec files#196jtgreen86 wants to merge 8 commits into
jtgreen86 wants to merge 8 commits into
Conversation
jtgreen86
force-pushed
the
fix/auto-update-fileversion-setting
branch
from
August 18, 2026 13:12
f1886b6 to
a6dead2
Compare
jtgreen86
force-pushed
the
fix/auto-update-fileversion-setting
branch
from
August 18, 2026 13:15
a6dead2 to
f55c58c
Compare
JasonConger
reviewed
Aug 19, 2026
JasonConger
reviewed
Aug 19, 2026
JasonConger
reviewed
Aug 19, 2026
JasonConger
reviewed
Aug 19, 2026
JasonConger
requested changes
Aug 19, 2026
JasonConger
left a comment
Collaborator
There was a problem hiding this comment.
We updated the actions to use v7 recently. The MR uses v4 in build-test.yaml. Please test with v7. I don't anticipate any issues, but let's check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an oversight in the spec file update workflow where new Splunk versions were downloaded to
spec_files/but not added to thesplunk.spec.FileVersionsetting inpackage.json. Users had to manually update the extension settings to use newly downloaded spec files.Changes
updatePackageJsonVersions()function toscripts/update-spec-files.jsthat automatically:splunk.spec.FileVersionenum.github/copilot-instructions.mdpackage.jsonwith missing versions: 9.3, 9.4, 10.0, 10.2, 10.4Test Plan
node scripts/update-spec-files.js --check-only --verboseto verify script parses correctlypackage.jsonenum matchesspec_files/directoriesnpm testto ensure no regressions