Skip to content

Update to Wasmtime 46 and WASI 0.3.0, retaining support for 0.3.0-rc-2026-03-15#3595

Merged
dicej merged 5 commits into
spinframework:mainfrom
dicej:wasmtime-46
Jul 7, 2026
Merged

Update to Wasmtime 46 and WASI 0.3.0, retaining support for 0.3.0-rc-2026-03-15#3595
dicej merged 5 commits into
spinframework:mainfrom
dicej:wasmtime-46

Conversation

@dicej

@dicej dicej commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

The first commit just updates Wasmtime; the second commit adds shims to support 0.3.0-rc-2026-03-15.

This is a draft for now, while I investigate an odd regression in test_max_memory_size_violated. EDIT: this seems to be due to how my local version of Rust compiles the guest code rather than anything that changed in Spin or Wasmtime.

@dicej dicej force-pushed the wasmtime-46 branch 3 times, most recently from 219d99a to 8410a57 Compare July 6, 2026 18:00
@dicej dicej marked this pull request as ready for review July 6, 2026 18:12
@dicej dicej marked this pull request as draft July 6, 2026 20:30
dicej added 3 commits July 7, 2026 08:31
Signed-off-by: Joel Dice <joel.dice@akamai.com>
Signed-off-by: Joel Dice <joel.dice@akamai.com>
Signed-off-by: Joel Dice <joel.dice@akamai.com>
See spinframework#3598 for details.

Signed-off-by: Joel Dice <joel.dice@akamai.com>
Signed-off-by: Joel Dice <joel.dice@akamai.com>
@dicej dicej marked this pull request as ready for review July 7, 2026 17:42
@dicej dicej requested a review from alexcrichton July 7, 2026 19:32

@alexcrichton alexcrichton left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Clearly a lot of work went into this and I'm glad at least that it all worked out without having any hiccups to address upstream in addition to this. I looked over everything and it all looks good to me 👍

The one bit I'm not the most comfortable reviewing is the CI adjustments, but if you've already discussed that with others that sounds reasonable too

@dicej dicej requested a review from itowlson July 7, 2026 21:38

@itowlson itowlson left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maintainer rubber-stamp for Alex's review!

@dicej dicej merged commit 6900ea4 into spinframework:main Jul 7, 2026
32 of 33 checks passed
@dicej dicej deleted the wasmtime-46 branch July 7, 2026 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants