blockchain: move blockchain logic from module to class - #10876
Open
f321x wants to merge 2 commits into
Open
Conversation
os.system() is marked deprecated, the docs say to use subprocess instead.
move the blockchain logic in `blockchain.py` from the module level into a class whose instance is owned by the Network. This separates the blockchain handling from the process and allows to have different blockchain setups in the same process, which can e.g. be used in unittests as unittests might simulate different "users" in a single process.
f321x
force-pushed
the
blockchain_manager
branch
from
August 20, 2026 12:36
8f906ed to
45ad677
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the blockchain logic in
blockchain.pyfrom the module levelinto a
BlockchainManagerclass whose instance is owned by theNetwork.This separates the blockchain handling from the process and allows
to have different blockchain setups in the same process, which can
e.g. be used in unittests, as those might simulate different
"users" in a single process.