Skip to content

Upgrade jaeger pack to 4.12.0 - #298

Open
CarlosRamirezSWO wants to merge 1 commit into
spectrocloud:mainfrom
CarlosRamirezSWO:jaeger-4120
Open

Upgrade jaeger pack to 4.12.0#298
CarlosRamirezSWO wants to merge 1 commit into
spectrocloud:mainfrom
CarlosRamirezSWO:jaeger-4120

Conversation

@CarlosRamirezSWO

Copy link
Copy Markdown
Contributor

Upgrade jaeger pack to 4.12.0

@bulwark-sc-ent bulwark-sc-ent Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ CVE scan completed successfully.

Scan Summary:

  • Total images scanned: 1
  • Clean images: 0
  • Images with CVEs: 1
  • Total CVEs found: 7

🔴 Critical CVEs: 0
🟠 High CVEs: 1
🟡 Medium CVEs: 0
🟢 Low CVEs: 6

Images with CVEs:

  • jaegertracing/jaeger:2.20.0: 7 CVEs (Critical: 0, High: 1, Medium: 0, Low: 6)

⚠️ Please review the CVE findings above and address critical/high severity issues before merging.

@bulwark-sc-ent bulwark-sc-ent Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ CVE scan completed successfully.

Scan Summary:

  • Total images scanned: 1
  • Clean images: 0
  • Images with CVEs: 1
  • Total CVEs found: 7

🔴 Critical CVEs: 0
🟠 High CVEs: 1
🟡 Medium CVEs: 0
🟢 Low CVEs: 6

Images with CVEs:

  • jaegertracing/jaeger:2.20.0: 7 CVEs (Critical: 0, High: 1, Medium: 0, Low: 6)

⚠️ Please review the CVE findings above and address critical/high severity issues before merging.

@vishwanaths

Copy link
Copy Markdown
Collaborator

Pack review — jaeger-4.12.0

Packs Validation: passed (run)
source annotation: community
Pack metadata: name=jaeger version=4.12.0 addonType=monitoring layer=addon displayName=Jaeger contributor=spectrocloud

Compared against packs/jaeger-4.11.1/

Summary of differences

  • pack.json: minor version bump 4.11.1 -> 4.12.0; charts entry updated to charts/jaeger-4.12.0.tgz. No changes to annotations, addonType, layer, cloudTypes, or constraints.
  • values.yaml (pack-level): bumps jaegertracing/jaeger image tag 2.19.0 -> 2.20.0; helm chart version 4.11.1 -> 4.12.0; adds a new default charts.jaeger.jaeger.podAnnotations block exposing prometheus.io/port: "8888" and prometheus.io/scrape: "true" (previously hardcoded in the deploy template).
  • charts/jaeger/Chart.yaml: appVersion 2.19.0 -> 2.20.0, chart version 4.11.1 -> 4.12.0, and the artifacthub.io/images annotation follows the same image tag bump.
  • charts/jaeger/Chart.lock: bitnami common subchart bumped 2.34.0 -> 2.36.0 (new digest / generation timestamp).
  • charts/jaeger/values.yaml: matching new default jaeger.podAnnotations map (prometheus scrape defaults).
  • charts/jaeger/templates/jaeger/jaeger-deploy.yaml: prometheus scrape annotations are no longer hardcoded on the pod template; now rendered from .Values.jaeger.podAnnotations via toYaml. Same effective defaults, but users can now override.
  • charts/jaeger/charts/common/Chart.yaml: bitnami common lib version/appVersion 2.34.0 -> 2.36.0.
  • charts/jaeger/charts/common/templates/_capabilities.tpl: common.capabilities.vpa.apiVersion now unconditionally returns autoscaling.k8s.io/v1 (previously returned autoscaling/v1beta2 for k8s <1.25 else autoscaling/v1). This is an upstream bitnami common-lib change and matches the real VPA API group.
  • charts: jaeger-4.11.1.tgz (35 899 B) -> jaeger-4.12.0.tgz (35 928 B) (+29 B, +0.08%); chart contents themselves were not inspected.
  • logo.png: unchanged (identical blob).
  • Files added/removed: none beyond the version-suffixed pack directory rename.

pack.json diff

--- a/packs/jaeger-4.11.1/pack.json
+++ b/packs/jaeger-4.12.0/pack.json
@@ -5,11 +5,11 @@
   ],
   "displayName": "Jaeger",
   "charts": [
-    "charts/jaeger-4.11.1.tgz"
+    "charts/jaeger-4.12.0.tgz"
   ],
   "layer": "addon",
   "name": "jaeger",
-  "version": "4.11.1",
+  "version": "4.12.0",
   "annotations": {
     "source": "community",
     "contributor": "spectrocloud"

values.yaml diff (pack-level)

--- a/packs/jaeger-4.11.1/values.yaml
+++ b/packs/jaeger-4.12.0/values.yaml
@@ -4,12 +4,12 @@ pack:
   namespace: "jaeger"
   content:
     images:
-      - image: jaegertracing/jaeger:2.19.0
+      - image: jaegertracing/jaeger:2.20.0

     charts:
       - repo: https://jaegertracing.github.io/helm-charts
         name: jaeger
-        version: 4.11.1
+        version: 4.12.0

@@ -254,6 +254,9 @@ charts:
       tolerations: []
       affinity: {}
       topologySpreadContraints: []
+      podAnnotations:
+        prometheus.io/port: "8888"
+        prometheus.io/scrape: "true"
       podSecurityContext:
         runAsUser: 10001
         runAsGroup: 10001

Blockers

  • None.

Nits / observations

  • The security-scans/syft-license check on this PR is failing (spectrocloud/bulwark run 31636453735). It is outside the Packs Validation gate this reviewer enforces, but a maintainer may want to eyeball it before merging in case a new bitnami-common licence surfaced in the 2.36.0 bump.
  • Pre-existing typo topologySpreadContraints (missing s in "Constraints") is still present in charts/jaeger/values.yaml and the pack values.yaml — carried over from 4.11.1, not introduced here.
  • VPA API-group correction (autoscaling.k8s.io/v1) is a behaviour change vs. 4.11.1: any downstream cluster that previously received autoscaling/v1 VPA objects (from k8s >=1.25) will now get the correct group. VPA CRDs are the target either way, so this should be an improvement — worth a smoke test on an existing consumer if you have one.

Review generated by the pack-reviewer Claude Code subagent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants