fix: improve DB setup script

.env

@@ -3,6 +3,10 @@ DATABASE_PORT=3306
 MYSQL_ROOT_PASSWORD=password
 DATABASE_NAME=specify
 
+# This allows for a destructive reset of the database if it is not empty but contains no legacy Specify schema.
+# For production environments, it is recommended to set this to false to prevent accidental data loss.
+ALLOW_DB_RESET=false
+
 # The following are database users with specific roles and privileges. 
 # If the migrator and app user are not defined, the system will use the master user credentials.
 # See documenation https://discourse.specifysoftware.org/t/new-blank-database-creation-database-user-levels/3023

Makefile

@@ -15,7 +15,7 @@ pip_requirements:
 	$(PIP) install --upgrade -r requirements.txt
 
 django_migrations:
-	$(PYTHON) manage.py base_specify_migration --database=migrations
+	$(PYTHON) manage.py base_specify_migration --use-override --database=migrations
 	$(PYTHON) manage.py migrate --database=migrations
 
 specifyweb/settings/build_version.py: .FORCE

docker-compose.yml

@@ -24,9 +24,6 @@ services:
     command: --max_allowed_packet=1073741824
     environment:
       - MYSQL_ROOT_PASSWORD=${MYSQL_ROOT_PASSWORD}
-      - MYSQL_DATABASE=${DATABASE_NAME}
-      - MYSQL_USER=${MASTER_NAME}
-      - MYSQL_PASSWORD=${MASTER_PASSWORD}
 
   specify7:
     container_name: specify7
@@ -35,7 +32,6 @@ services:
       target: run-development
     command: ve/bin/python manage.py runserver 0.0.0.0:8000
     init: true
-    restart: unless-stopped
     depends_on:
       # It seems like there was a race condition on the the
       # webpack-output volume. I suspect if this container mounts it

docker-entrypoint.sh

@@ -8,12 +8,13 @@ if [ "$1" = 've/bin/gunicorn' ] || [ "$1" = 've/bin/python' ]; then
   echo "Updating static files in /volumes/static-files/."
   rsync -a --delete specifyweb/frontend/static/ /volumes/static-files/frontend-static
   cd /opt/specify7
-  echo "Applying Django migrations."
-  set +e
-  ./sp7_db_setup_check.sh # Setup db users and run mirgations
-  # ve/bin/python manage.py base_specify_migration
-  # ve/bin/python manage.py migrate
-  ve/bin/python manage.py run_key_migration_functions # Uncomment if you want the key migration functions to run on startup.
-  set -e
+  if ./sp7_db_setup_check.sh; then
+    # sp7_db_setup_check.sh intentionally runs manage.py base_specify_migration and manage.py migrate;
+    # only manage.py run_key_migration_functions is invoked here afterward.
+    ve/bin/python manage.py run_key_migration_functions # Runs after sp7_db_setup_check.sh succeeds.
+  else
+    echo "Database setup failed; exiting."
+    exit 1
+  fi
 fi
-exec "$@"
+exec "$@"