Yices: Use official repository for building the Java bindings#660
Yices: Use official repository for building the Java bindings#660daniel-raffler wants to merge 3 commits into
Conversation
Our changes have been merged into main, so the fork is no longer needed
Downloading the 'latest' release lead to some path issues in the build script
| <!-- Download a more recent Jdk to avoid compile errors --> | ||
| <get src="https://download.oracle.com/java/21/latest/jdk-21_windows-x64_bin.zip" dest="/dependencies" verbose="true"/> | ||
| <unzip src="/dependencies/jdk-21_windows-x64_bin.zip" dest="/dependencies"/> | ||
| <get src="https://download.oracle.com/java/21/archive/jdk-21.0.10_windows-x64_bin.zip" dest="/dependencies" verbose="true"/> |
There was a problem hiding this comment.
@PhilippWendler do we need to add a license of we use Oracle JDKs?
There was a problem hiding this comment.
One always needs a license for every piece of software that one uses.
Whether the current license of the Oracle JDK allows us to use it for free I don't know, you have to check.
There was a problem hiding this comment.
Thank you! We will take a look and add the appropriate license if needed.
There was a problem hiding this comment.
What do you mean with "add"? Why and where would you want to "add" a license? The license is specified by Oracle, not us. We need to be given a license that allows us to use the software.
| # name of the library | ||
| -libyices2java := libyices2java.$(EXTENSION) | ||
| +ifeq ($(OS),win32) | ||
| + libyices2java := yices2java.$(EXTENSION) |
There was a problem hiding this comment.
libyices2java is hardcoded as a name several times below. Do we need to update those as well?
3 participants
Hello,
this PR changes the build script for Yices so that the Java bindings are built directly from the official repository. We used to have a fork with some changes, but since everything has now been merged into
mainthis will no longer be necessary(see SRI-CSL/yices2_java_bindings#8 for our pull request)