fix: 프로덕션 색인 대상 정리#599
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Walkthrough이번 PR은 대학교 리스트 관련 레거시 URL 처리 방식을 rewrite에서 redirect로 바꾸고, 두 서비스(apps/web, apps/university-web)의 sitemap.ts에서 Estimated code review effort: 2 (Simple) | ~10 minutes Changes
Sequence Diagram(s)sequenceDiagram
participant Browser
participant NextConfig
Browser->>NextConfig: GET /university/list/inha/path
NextConfig-->>Browser: 308 permanent redirect to /university/inha/path
Suggested reviewers: 🐰 리다이렉트 하나 심어놓고, 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/university-multizone-deployment.md`:
- Line 34: The current wording around /university/list/:homeUniversity only
describes the main redirect, but the actual behavior also includes child-route
forwarding via the legacy-to-canonical redirect rules. Update the documentation
text to explicitly mention that /university/list/:homeUniversity/:path* is
redirected to /university/:homeUniversity/:path*, so the description matches the
behavior defined by the redirect logic and the Next.js config.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 2d5527d9-4d54-4231-8910-d22c129a4440
📒 Files selected for processing (4)
apps/university-web/src/app/sitemap.tsapps/web/next.config.mjsapps/web/src/app/sitemap.tsdocs/university-multizone-deployment.md
💤 Files with no reviewable changes (2)
- apps/university-web/src/app/sitemap.ts
- apps/web/src/app/sitemap.ts
| - `/university-static/*` | ||
|
|
||
| `/university/list/:homeUniversity`는 legacy URL로만 취급한다. child route는 유지하지 않고, main rewrite에서 `/university/:homeUniversity` SSG 페이지로 보낸다. 이렇게 하면 오래된 외부 링크는 살리면서 SSG catalog 안에 client-fetch 목록 페이지가 섞이지 않는다. | ||
| `/university/list/:homeUniversity`는 legacy URL로만 취급한다. child route는 유지하지 않고, main redirect에서 `/university/:homeUniversity` SSG 페이지로 보낸다. 이렇게 하면 오래된 외부 링크는 canonical URL로 정리하면서 SSG catalog 안에 client-fetch 목록 페이지가 섞이지 않는다. |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf '\n== Files ==\n'
git ls-files | rg '^(docs/university-multizone-deployment\.md|apps/web/next\.config\.mjs)$'
printf '\n== Doc snippet ==\n'
cat -n docs/university-multizone-deployment.md | sed -n '28,40p'
printf '\n== next.config search ==\n'
rg -n '/university/list|redirect|pathname|source|destination' apps/web/next.config.mjs
printf '\n== next.config snippet ==\n'
cat -n apps/web/next.config.mjs | sed -n '70,95p'Repository: solid-connection/solid-connect-web
Length of output: 3138
1. 문구를 하위 경로 리다이렉트까지 맞춰주세요.
apps/web/next.config.mjs에는 /university/list/:homeUniversity/:path* -> /university/:homeUniversity/:path* 규칙도 있어서, child route가 그대로 canonical 하위 경로로 이어집니다. 지금의 “child route는 유지하지 않는다”는 실제 동작과 어긋나니, 이 부분까지 반영해 문구를 다듬어 주세요.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/university-multizone-deployment.md` at line 34, The current wording
around /university/list/:homeUniversity only describes the main redirect, but
the actual behavior also includes child-route forwarding via the
legacy-to-canonical redirect rules. Update the documentation text to explicitly
mention that /university/list/:homeUniversity/:path* is redirected to
/university/:homeUniversity/:path*, so the description matches the behavior
defined by the redirect logic and the Next.js config.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
관련 이슈
작업 내용
noindex가 적용된/university/search를 web/university-web sitemap에서 제거했습니다./university/list/:homeUniversityURL을 rewrite 대신 canonical URL인/university/:homeUniversity로 permanent redirect 처리했습니다.검증
NEXT_PUBLIC_API_SERVER_URL=https://api.solid-connection.com NEXT_PUBLIC_WEB_URL=https://www.solid-connection.com pnpm --filter @solid-connect/university-web run buildUNIVERSITY_WEB_DOMAIN=https://www.solid-connection.com NEXT_PUBLIC_API_SERVER_URL=https://api.solid-connection.com NEXT_PUBLIC_WEB_URL=https://www.solid-connection.com pnpm --filter @solid-connect/web run buildpnpm --filter @solid-connect/web run lint:checkpnpm --filter @solid-connect/web run typecheck:cipnpm --filter @solid-connect/university-web run lint:checkpnpm --filter @solid-connect/university-web run typecheck:ci특이 사항
homeUniversityId=1인하대 목록은 0개,homeUniversityId=2경희대 목록은 189개입니다. 따라서 기존 인하대 상세 URL의 404는 데이터 기준으로 사라진 URL이며, 이번 PR은 sitemap/noindex 불일치와 legacy URL 중복 신호를 줄이는 정리입니다.리뷰 요구사항 (선택)
/university/list/:homeUniversity/:path*redirect가 legacy 상세/하위 경로에 기대한 canonical URL을 만드는지 확인 부탁드립니다.