Skip to content

fix(sign-up): 이메일 회원가입 폼 접근성 보완#598

Open
wibaek wants to merge 1 commit into
mainfrom
fix/email-signup-form-accessibility
Open

fix(sign-up): 이메일 회원가입 폼 접근성 보완#598
wibaek wants to merge 1 commit into
mainfrom
fix/email-signup-form-accessibility

Conversation

@wibaek

@wibaek wibaek commented Jul 4, 2026

Copy link
Copy Markdown
Member

요약

  • 이메일 회원가입 폼의 label 연결과 입력 필드 semantics를 보완했습니다.
  • 비밀번호 보기/숨기기 아이콘 버튼에 접근 가능한 이름을 추가했습니다.

변경 사항

  • 이메일, 비밀번호, 비밀번호 확인 input에 idname을 추가했습니다.
  • 이메일 input에 spellCheck={false}를 추가했습니다.
  • 비밀번호 보기/숨기기 버튼에 상태별 aria-label을 추가했습니다.

검증

  • 브라우저 DOM 확인: input label 연결, name, email spellcheck, icon button aria-label 확인
  • /opt/homebrew/bin/pnpm --filter @solid-connect/web run lint
  • /opt/homebrew/bin/pnpm --filter @solid-connect/web run typecheck
  • pre-push @solid-connect/web ci:check 및 build 통과

노트

  • 하단 버튼 정렬 수정 PR과 분리한 접근성 보완 PR입니다.

@wibaek wibaek requested review from enunsnv and manNomi as code owners July 4, 2026 17:39
@vercel

vercel Bot commented Jul 4, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
solid-connect-university-web Ready Ready Preview, Comment Jul 4, 2026 5:42pm
solid-connection-web Ready Ready Preview, Comment Jul 4, 2026 5:42pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
solid-connect-web-admin Skipped Skipped Jul 4, 2026 5:42pm

@coderabbitai

coderabbitai Bot commented Jul 4, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@wibaek, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 37 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 36f4e14e-10e2-4cc5-bc4f-3d7aab911692

📥 Commits

Reviewing files that changed from the base of the PR and between 239c0ff and 192edae.

📒 Files selected for processing (1)
  • apps/web/src/app/sign-up/email/EmailSignUpForm.tsx
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/email-signup-form-accessibility

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant