program: Cap increase to 50 basis points#791
Draft
joncinque wants to merge 2 commits into
Draft
Conversation
#### Problem The fee check is using `map` instead of `and_then`, allowing for an incorrect comparison between `Option::Some(...)` and `Option::None`. #### Summary of changes Use `and_then` instead to compare numbers instead of options.
#### Problem The program currently caps the withdrawal fee increase to 1.5x, which can be a lot at higher numbers. #### Summary of changes Also cap any increase to 50 basis points.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The program currently caps the withdrawal fee increase to 1.5x, which can be a lot at higher numbers.
Summary of changes
Also cap any increase to 50 basis points.
Note: this PR builds on top of #790, so should be merged afterwards. It is also included in the most recent release of the stake pool program on mainnet: https://github.com/solana-program/stake-pool/releases/tag/program%40v2.1.0