build: upgrade to TypeScript 7 - #827
Conversation
Co-authored-by: Codex <noreply@openai.com>
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (22)
💤 Files with no reviewable changes (6)
📝 WalkthroughWalkthroughThe repository updates its TypeScript development toolchain to TypeScript 6 and native TypeScript 7, removes ChangesTypeScript toolchain upgrade
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Important UI Tests need review – Review now🟡 UI Tests: softmaple_packages/awareness: 38 visual and accessibility changes must be accepted as baselines |
|
Important Testing in progress…🟢 UI Tests: softmaple-packages/editor: 8 tests unchanged |
|
Tip All tests passed and all changes approved!🟢 UI Tests: softmaple-packages/editor: 8 tests unchanged |
Coverage Report for packages/awareness
File CoverageNo changed files found. |
Coverage Report for packages/eg-walker
File CoverageNo changed files found. |
Summary
baseUrlsettings and add explicit Node ambient types where the new defaults require themeg-walkerdeclaration buildThis follows the TypeScript 7 migration guidance while the stable programmatic API is still transitioning.
Closes #825.
Performance
Measured on an Apple M1 MacBook Pro with 16 GB RAM and Node 24.12.0. The web comparison used seven warmed, alternating direct runs of:
tsc -p apps/web/tsconfig.json --noEmit --pretty false--extendedDiagnosticscompiler time improved from 2.57 s to 0.45 s (5.71x), while peak memory fell by 36.1%.Across five representative workspace configurations, the co-installed TS6 API bridge took 11.54 s in aggregate versus 2.23 s for native TS7, a 5.17x speedup.
Validation
pnpm install --offline --frozen-lockfilepnpm build— 7/7 production build tasks passedpnpm --filter @softmaple/web lintpnpm --filter @softmaple/eg-walker lintgit diff --checkExisting unrelated failures
pnpm lintstill reports existing Biome errors in unchanged playground source files; targeted checks for this change pass.eg-walkerdeferred-text-materialization property test reproducibly exposes a runtime algorithm defect after hundreds of generated traces. Noeg-walkerruntime or test source changed here; the other 710 tests pass, including the convergence property when rerun in isolation.Screenshots are not applicable because this change has no UI impact.
Summary by CodeRabbit