refactor: always use native Snyk Code workflow - #160
Conversation
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This comment has been minimized.
This comment has been minimized.
755d0e4 to
80d5e40
Compare
PR Reviewer Guide 🔍
|
|
|
||
| func useNativeImplementation(config configuration.Configuration, logger *zerolog.Logger, sastEnabled bool, scleEnabled bool) bool { | ||
| useConsistentIgnoresFF := config.GetBool(configuration.FF_CODE_CONSISTENT_IGNORES) | ||
| useNativeImplementationFF := config.GetBool(configuration.FF_CODE_NATIVE_IMPLEMENTATION) |
There was a problem hiding this comment.
Can we remove the evaluation here?
The snykCodeClientNativeImplementation is disabled in fedRAMP env.
https://github.com/snyk/registry/blob/4b930c34f61661b32e27d9d2ceb086a71337b58d/helm/values/fedramp-production.yaml#L83
| } | ||
|
|
||
| func useNativeImplementation(config configuration.Configuration, logger *zerolog.Logger, sastEnabled bool, scleEnabled bool) bool { | ||
| useConsistentIgnoresFF := config.GetBool(configuration.FF_CODE_CONSISTENT_IGNORES) |
There was a problem hiding this comment.
This is still an org/group level feature flag.
https://github.com/snyk/registry/blob/4b930c34f61661b32e27d9d2ceb086a71337b58d/src/lib/domain/internal-developer-tooling/features/index.ts#L1249-L1251
Despite it is set to ' true ' by default, customers can still disable it in the org/group settings page.
Can we remove the evaluation here?
| } | ||
|
|
||
| scleEnabled := config.GetBool(ConfigurationSlceEnabled) | ||
| nativeImplementation := useNativeImplementation(config, logger, sastEnabled, scleEnabled) |
There was a problem hiding this comment.
Any chance that both flags would be set to false?
2 participants
Description
Remove the remaining legacy CLI dispatch branch from the code-client-go workflow. The
code.testworkflow now always recordsimplementation=native, registers the SCLE auth URL when needed, and runscode_workflow.EntryPointNativedirectly.This also removes the native/consistent-ignores feature-flag gate from
Init, deletes theEntryPointLegacywrapper, updates tests that previously exercised the legacy fallback, and updates README workflow documentation.Checklist
Validation run locally:
make formatgo mod tidygo build ./...go test -cover ./...go test ./pkg/code ./internal/commands/code_workflowgofmt -w -l -e pkg/code/code.go pkg/code/code_test.go.bin/golangci-lint run --fix ./pkg/code/... ./internal/commands/code_workflow/...Known local validation blocker:
make generatecould not complete becausescripts/download-test-api.pyrequiresGITHUB_PATto be set.🚨 After having merged, please update the
snyk-lsand CLI go.mod to pull in latest client.