fix: stop deleting HTML output for zip-output networks#17
Open
matan-rahmani wants to merge 1 commit into
Open
Conversation
The rmSync cleanup added in v1.1.3 deletes the temporary webpack output folder after ZipPlugin runs. This removes the HTML files that downstream build pipelines rely on to discover and upload per-network builds (google, mintegral, vungle, etc.). Without the HTML on disk, pipelines that scan dist/ for .html files silently skip these networks. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fs.rmSynccleanup of the temporary webpack output folder after ZipPlugin runs (added in v1.1.3)dist/for.htmlfiles silently skip these networksContext
The ZipPlugin produces a
.zipin the parent output directory, then the cleanup deletes the subfolder containing the source HTML. Build pipelines rely on finding those.htmlfiles to copy them intoSETT_TEST_HTML/and include them in manifests. The cleanup breaks this for all zip-output networks.