Skip to content

Address async retry refactor review follow-ups#723

Merged
jonathan343 merged 1 commit into
smithy-lang:developfrom
jonathan343:retries-cleanup-followup
Jun 23, 2026
Merged

Address async retry refactor review follow-ups#723
jonathan343 merged 1 commit into
smithy-lang:developfrom
jonathan343:retries-cleanup-followup

Conversation

@jonathan343

Copy link
Copy Markdown
Contributor

Overview

Minor follow-ups from the async RetryStrategy refactor (#671), addressing review feedback we deferred to a separate PR.

Changes

  • Await the async transport send and deserialize calls in the designs/retries.md example.
  • Import RetryStrategyType from ..retries in aio/retries.py instead of redefining the Literal alias.
  • Fix the dangling RetryStrategy cross-reference in the RetryToken docstring, since the protocol moved to smithy_core.aio.interfaces.retries.
  • Expand the changelog entry to note the module relocations, and add a trailing newline.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jonathan343 jonathan343 requested a review from a team as a code owner June 21, 2026 05:26

@SamRemis SamRemis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Jonathan!

@jonathan343 jonathan343 merged commit 24e328c into smithy-lang:develop Jun 23, 2026
8 checks passed
@jonathan343 jonathan343 deleted the retries-cleanup-followup branch June 23, 2026 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants