feat: refactor token verifier factory - #1365
Open
huangzhen1997 wants to merge 3 commits into
Open
Conversation
|
👋 huangzhen1997, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
huangzhen1997
force-pushed
the
NONEVM-5852/export-token-verifier-factory
branch
from
August 20, 2026 02:46
4b35ed7 to
c9940de
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces configurable resilience policies for indexer “resilient readers” (rate limiting / bulkhead / circuit breaker / timeouts) via top-level indexer config, and refactors the token verifier binary to use a shared service-factory implementation in cmd/verifier.
Changes:
- Add
[Resilience]to indexer config and plumb the resulting settings through indexer reader construction (REST + Aggregator). - Introduce
readers.NewResilienceConfig(config.ResilienceConfig)plus unit tests to default/override resilience settings. - Refactor
cmd/verifier/tokento use a newcmd/verifier/tokenfactory.goservice factory (moving the previous in-main implementation).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| indexer/pkg/readers/rest_reader.go | Accept resilience policies via RestReaderConfig and pass through to resilient wrapper |
| indexer/pkg/readers/rest_reader_test.go | Update REST reader tests to pass resilience config explicitly |
| indexer/pkg/readers/resilient_reader.go | Add config-to-reader resilience translation helper (NewResilienceConfig) |
| indexer/pkg/readers/resilient_reader_test.go | New unit tests for resilience translation/defaulting behavior |
| indexer/pkg/readers/aggregator_reader.go | Extend aggregator reader factory to accept resilience config and set discovery handlers |
| indexer/pkg/config/config.go | Add Config.Resilience and define TOML-backed ResilienceConfig |
| indexer/config.example.toml | Document example [Resilience] values |
| indexer/cmd/replay/main.go | Thread resilience config into verifier/discovery reader creation |
| indexer/cmd/main.go | Thread resilience config into verifier/discovery reader creation |
| cmd/verifier/tokenfactory.go | New shared token-verifier ServiceFactory implementation |
| cmd/verifier/token/main.go | Switch token verifier binary to use the new shared ServiceFactory |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Code coverage report:
Files added (in
|
makramkd
approved these changes
Aug 20, 2026
Comment on lines
+31
to
+47
| type tokenFactory struct { | ||
| bootstrap.ServiceFactory | ||
|
|
||
| coordinators []*verifier.Coordinator | ||
| httpServer *http.Server | ||
| lggr logger.Logger | ||
| } | ||
|
|
||
| // NewTokenVerifierServiceFactory creates a new ServiceFactory for the token verifier service. | ||
| // The factory loads the verifier secrets file itself in Start, so each chain-family binary's | ||
| // main.go stays free of secrets-loading boilerplate. | ||
| func NewTokenVerifierServiceFactory() bootstrap.ServiceFactory { | ||
| return &tokenFactory{} | ||
| } | ||
|
|
||
| // Stop tries to stop all services gracefully. | ||
| func (tvf *tokenFactory) Stop(_ context.Context) error { |
Contributor
There was a problem hiding this comment.
tiny nit: tvf let's sync naming convention :) looks like it used to be tokenVerifierFactory and renamed to tokenFactory
jadepark-dev
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Export the token verifier factory to support standalone mode token verifier in chain family repo.